Expose CROSSPLANE_NAMESPACE to uptest #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbbush
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
ytsarev
approved these changes
Jan 24, 2024
|
/test-examples="examples/docdb/cluster.yaml" just in case, to have a centralized uptest run |
mbbush
added a commit
to spanio/upbound-provider-aws
that referenced
this pull request
Feb 15, 2024
ulucinar
pushed a commit
to ulucinar/upbound-provider-aws
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Since we started consuming upbound/official-providers-ci#169, running
make uptestormake e2elocally fails on the import step unless the CROSSPLANE_NAMESPACE env var is defined. This sets it in the uptest makefile step.It would be great to backport this to at least 0.47, just to make local development on that branch easier, but I don't think I have permission to add the appropriate label.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Running uptest locally now passes without any additional env vars set.